Linxiaoli/vsl 236 and vsl 263: integrate with API and show error message and implement subscribe all community flow by linxiao-li · Pull Request #698 · DapperCollectives/CAST

linxiao-li · 2022-10-31T21:14:10Z

This pr includes:

Integration of the Leanplum api calls for getting and setting the user, updating community subscriptions
Have updateCommunitySubscription accepting an array as argument to allow bulk subscription subscribe/unsubscribe

Demo:

connect wallet and render settings page with Leanplum data flow

connect.wallet.and.populate.settings.page.mov

subscribe to all email notification flow

subscribe.to.all.email.notifications.mov

change email flow

change.email.flow.mov

subscribe to community from settings page flow

subscribe.to.community.mov

subscribe from community page flow

subscribe.from.community.page.mov

linear · 2022-10-31T21:14:13Z

VSL-236

linxiao-li · 2022-10-31T21:15:03Z

frontend/packages/client/src/api/notificationService.js

 };

-export const startLeanplum = () => {
+const getDesiredAttributes = (communitySubIntentions) => {


This is to convert the array in line 18 into a format of {community1:'True', community2:'False'}

linxiao-li · 2022-10-31T21:17:29Z

frontend/packages/client/src/api/notificationService.js

-  } catch (e) {
-    throw new Error(e);
-  }
+  return new Promise((resolve, reject) => {


Returning a promise is necessary for ensuring the sequence of execution, we want start leanplum first then get user settings

linxiao-li · 2022-10-31T21:17:59Z

frontend/packages/client/src/api/notificationService.js

      email: data.userAttributes.email,
    };
-    let isSubscribedToCommunityUpdates = true;
+    let isSubscribedFromCommunityUpdates = true;


Naming correction to align the names with the notion document

linxiao-li · 2022-10-31T21:22:19Z

frontend/packages/client/src/components/Settings/NotificationSettingsSection/CommunitiesList.js

+      count: 100,
+      initialLoading: false,
+    });
+  const displayCommunities = isLoadingUserCommunities


This is a list of all communities a user participates, if leanplum userAttributes doesn't have a community, it will render that community still but with notification turned off

under Settings it should only display list of communities that user subscribed before, looks like previous code is correct. Any reason we are changing this to be all communities?

Got it, I misunderstood the design, will change it back

amyliu6 · 2022-10-31T21:37:17Z

hi @linxiao-li for subscribe from community page flow, if user subscribed before (provided email before), they should only see a toast message like this figma: https://www.figma.com/file/fMU3bTuuYqGeY9Wg0bK9S8/CAST%3A-User-Experience?node-id=3484%3A57677, From video looks like instead of toast, email form showed up with prefilled email address, could you help take a look?

...end/packages/client/src/components/Settings/NotificationSettingsSection/EmailAddressInput.js

amyliu6 · 2022-10-31T22:17:13Z

frontend/packages/client/src/components/Settings/NotificationSettingsSection/CommunitiesList.js

+      count: 100,
+      initialLoading: false,
+    });
+  const displayCommunities = isLoadingUserCommunities


under Settings it should only display list of communities that user subscribed before, looks like previous code is correct. Any reason we are changing this to be all communities?

linxiao-li · 2022-11-01T16:22:10Z

@amyliu6 Got it, I misread the design. Just to double check, for the subscription flow I'm under the impression I only need to implement the functions for subscribe all communities and one community api call, the complete flow of subscription is going to be handled by this ticket?

amyliu6 · 2022-11-01T16:52:21Z

@amyliu6 Got it, I misread the design. Just to double check, for the subscription flow I'm under the impression I only need to implement the functions for subscribe all communities and one community api call, the complete flow of subscription is going to be handled by this ticket?

hi @linxiao-li the plan is to have all API integration in one ticket(236) as discussed during planning, hence we updated 232 to be testing only to verify the E2E flow. Given Manny is on leave this week, could you help with sanity test for subscription flow too so that QA can start testing both subscription flow and settings flow later this sprint?

linxiao-li · 2022-11-02T16:18:52Z

@amyliu6 Updated the user flows for updating subscriptions

sign up all notifications from community page for the first time

sign.up.all.from.community.page.mov

update subscription from the proposal page

update.subscription.from.proposal.page.mov

update subscription after voting

update.subscription.after.vote.mov

error modal

error.modal.mov

linxiao-li · 2022-11-02T16:30:32Z

frontend/packages/client/src/contexts/NotificationService.js

-        };
-      });
+      await updateCommunity(communitySubIntentions);
+      await new Promise((r) => setTimeout(r, 500));


This is to throttle the api calls, allow the data to get registered with leanplum before calling it again to get the updated data

amyliu6 · 2022-11-02T16:34:02Z

frontend/packages/client/src/contexts/NotificationService.js

+        email,
      }));
    } catch {
      throw new Error('cannot get user settings');


in case getUserSettings error, will user see error modal when they land on Settings page?

Not right now, if for any reason any of the user init functions failed (startLeanplum, setUserId, getUserSetting) we are only console logging the error. However, on the flow of updating subscriptions, getUserSetting error is caught and error modal shows up

i see, if getUserSettings failed, we won't be able to get user data, how is the current flow look like when user visit Settings page? Is it possible to display the error modal for that case too?

amyliu6 · 2022-11-02T16:35:20Z

frontend/packages/client/src/api/notificationService.js

-
+/* @param: communitySubIntentions : [{communityId:"1", subscribeIntention:"subscribe"},{communityId:"2",subscribeIntention:"unsubscribe"}]
+ * @return: {communityId1:'True', communityId2:'False'}
+ */


linxiao-li added 3 commits October 28, 2022 17:23

api integration done

9aab295

finish implementation

2574dcf

remove leanplum keys from env example

10781e3

linxiao-li commented Oct 31, 2022

View reviewed changes

amyliu6 reviewed Oct 31, 2022

View reviewed changes

full integration of the subscribe/unsubscribe flow

80c11b4

linxiao-li added 2 commits November 2, 2022 09:19

follow up

d672de4

add doc for function

4790c39

linxiao-li commented Nov 2, 2022

View reviewed changes

amyliu6 reviewed Nov 2, 2022

View reviewed changes

linxiao-li added 2 commits November 2, 2022 13:42

created retry modal and moved error handling from component to context

c92c3af

organize retry modal import

41e4bd1

Conversation

linxiao-li commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Oct 31, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amyliu6 commented Oct 31, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linxiao-li commented Nov 1, 2022

Uh oh!

amyliu6 commented Nov 1, 2022

Uh oh!

linxiao-li commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linxiao-li Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amyliu6 Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

linxiao-li commented Oct 31, 2022 •

edited

Loading

linxiao-li commented Nov 2, 2022 •

edited

Loading

linxiao-li Nov 2, 2022 •

edited

Loading

amyliu6 Nov 2, 2022 •

edited

Loading