[WIP] Load settings earlier because they are needed by the logger#65
Draft
ChillerDragon wants to merge 1 commit intomasterfrom
Draft
[WIP] Load settings earlier because they are needed by the logger#65ChillerDragon wants to merge 1 commit intomasterfrom
ChillerDragon wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
here the logger uses a config Line 20 in 33a6d5a but the settings file that loads the config variables also needs error logging server/lib/include/settings.sh Line 329 in 33a6d5a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem is that the logger depends on config vars for post logs dir
and config var loading depends on logger for error logging
add a
set -uto witness the error