Add Unity FixedString support to string builders#134
Open
Hertzole wants to merge 5 commits intoCysharp:masterfrom
Open
Add Unity FixedString support to string builders#134Hertzole wants to merge 5 commits intoCysharp:masterfrom
Hertzole wants to merge 5 commits intoCysharp:masterfrom
Conversation
Author
|
I've also added support for appending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the assembly definition aware of the Unity.Collections package and, if available, enables
AsFixedStringXXByteson bothUtf8ValueStringBuilderandUtf16ValueStringBuilder.There are checks in place to make sure the length of the buffer does not exceed what
FixedStringXXBytessupports. They will throwInvalidOperationExceptionif the byte count is exceeded.This was needed as it helps with the ECS migration in Unity. Unity's Netcode for GameObjects can also benefit from it.