block--with-button "include" template updates#69
Conversation
also, clean up docblock (copied from LASSP/Kavli)
ama39
left a comment
There was a problem hiding this comment.
It's possible you may need a <div class="constrain-480"> wrapper in the footer placement as well, but I can't be sure without seeing an example rendered. This 480 constraint is used to keep things aligned at certain awkward device sizes (the transition between phone and tablet).
|
@ama39 Oops, I definitely should've included links in the PR description 🤦♀️ [adding links now, in addition to here in this comment] The "changed version" of this block template is in use on the LASSP homepage, for both the News and Events blocks: The "Related news" block on People pages uses the (current/un-changed) cwd_base version of the block template in question: I just made an update on a LASSP multidev, to have that "people related news" block use the "changed version" of the block template, to confirm the changes won't mess anything up on existing uses of this block template: |
|
@ama39 I think this is good now, I think? |
|
@ama39 Do you think you could look at this PR this week, or unlikely? Thanks! |
These template changes are based on changes made on LASSP/Kavli.
Included changes:
To see the changes in action:
https://www.lassp.cornell.edu/
https://www.lassp.cornell.edu/people/tomas-arias
https://drupaug23-lassp.pantheonsite.io/people/tomas-arias