33 feat detect duplicate else if conditions as unreachable branches#34
Merged
SizzleUnrlsd merged 11 commits intomainfrom Feb 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added a new analysis pass that detects duplicate else if conditions that are logically unreachable. The analyzer now emits a DuplicateIfCondition warning with precise source locations. This was integrated into the diagnostics pipeline, added to the error-code enum, and wired into the build. We also added a set of diagnostic test cases covering positive detections (including commuted operands and nested scenarios) and negative cases (distinct conditions and separate if blocks).
Architecture rationale: we implemented this as its own analysis module and hooked it into the existing analysis pipeline rather than embedding the logic inside the main analyzer. This keeps responsibilities separated, makes the check independently testable, and avoids coupling with other diagnostics. Using dominator information and a lightweight source check balances precision with implementation cost, reducing false positives without requiring full AST-level parsing