Draft
Conversation
Adds new/dev/deploy/list/logs subcommands under `cone functions`. The dev server runs TypeScript functions through a MITM proxy that handles OAuth2+DPoP auth injection, egress allowlisting, and secret injection for production parity. Deploy is hidden from usage until the SDK exposes CreateCommit. Also updates go-jose to v4 (fixes decrypt command), updates vendor dependencies (baton-sdk, grpc, protobuf, etc.).
Ran `golangci-lint migrate` to add `version: "2"` and restructure the config for golangci-lint v2. Removes deprecated `varcheck` and `tenv` linters, moves `goimports` to formatters section.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
New code: - bodyclose: nolint directives for goproxy handler pattern - errcheck: handle Stop/Close/Serve return values - errorlint: use errors.As instead of type assertion - forbidigo: replace fmt.Println with pterm.Println - godot: end comments with periods - gosec: use 0600 file permissions, add ReadHeaderTimeout - noctx: use ListenConfig for context-aware listener - goimports: fix trailing whitespace Pre-existing: - staticcheck: lowercase error strings in get_drop_task.go - staticcheck: remove redundant embedded field selectors in entitlement.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cone functionscommand tree:new,dev,list,logs(+ hiddendeploypending SDKCreateCommitsupport)cone functions devruns TypeScript functions through a MITM proxy with OAuth2+DPoP auth injection, egress allowlisting, and secret injection for local-production paritycone functions newscaffolds a new function projectcone functions listandcone functions logsuse the existing SDK Functions APIsNote: golangci-lint v2 migration
Second commit migrates
.golangci.ymlto v2 format (golangci-lint migrate). The old config was missing the requiredversionfield, which breaks golangci-lint v2.x. This is a pre-existing issue on main -- the migration removes deprecatedvarcheck/tenvlinters and restructures the config. There are ~23 pre-existing lint issues in the repo unrelated to this PR.Test plan
cone functions new test-fncreates a valid project scaffoldcone functions devstarts proxy and deno processcone functions listreturns functions from APIcone functions logs <id>returns invocation historycone functions --helpdoes NOT showdeploycone functions deploy --dry-runstill works when called directly