baton-github: override static token with reuseToken in appClient#123
Merged
Bencheng21 merged 1 commit intomainfrom Feb 6, 2026
Merged
baton-github: override static token with reuseToken in appClient#123Bencheng21 merged 1 commit intomainfrom
Bencheng21 merged 1 commit intomainfrom
Conversation
WalkthroughRefactors JWT token sourcing in the connector by introducing a reusable token source and app JWT token refresher. The installation token flow now derives from refreshed app JWT tokens instead of one-shot tokens, with appClient overridden to use the shared jwtts token source. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Bencheng21
commented
Feb 5, 2026
| appClient, err = newGitHubClient(ctx, | ||
| ghc.InstanceUrl, | ||
| jwtts, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
looks like line 305 - 344 is unnecessary, but need to investigate why it's there.
johnallers
approved these changes
Feb 6, 2026
jugonzalez12
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before the fix
After the fix
Summary by CodeRabbit