Re-implement More Vanilla Turret patches

[sumghai]

Additions

• Re-implementation of compatibility patches for More Vanilla Turrets

Changes

• Fixed turrets not showing ammo gizmo and not firing
  • Cause of issue was an outdated weaponTag PatchOp that failed, and prevented subsequent patches from working properly
• Reduced Blast Turret ammo capacity to 48 40x53mm Grenades
  • Previous capacity was 75 grenades
  • Due to the bulk and mass of each 40x53mm Grenade ammo item, a typical pawn with a backpack cannot reload more than 50 grenades
  • When a pawn attempts to load more grenades than they can carry, they end up being stuck in a perpetual reloading loop
  • Lowering the capacity fixes this behaviour

References

• Contributes towards Import patches from FastTrack fork #1068
• Original implementation Add More Vanilla Turrets patches #1091
• Resolves Remove More Vanilla Turrets Patch. #1162

TODO:

• 81mm Plasma mortar currently not craftable
  • Plasma mortars can be spawned via dev mode, loaded by pawns into Devastator mortar and fired at targets
  • However, Plasma mortars do not show up in the Machining Bench's list of bills
  • I suspect that the ammo patcher is not recognizing the standalone ammoset created specifically for the Devastator mortar

[sumghai]

@N7Huntsman - I'm going to need some help with the issue where Plasma mortars are not craftable at the Machining Table/Bench , since they otherwise work correctly.

[MMMiracles]

100 seems a bit low when this thing can blow through that in 3 bursts. Doesn't quite sell the 'unrelenting lead storm' if it needs reloaded every other volley.

[N7Huntsman]

Plasma mortar is throwing an error when fired--it'll load and aim, but when it fires all the ammo disappears. I'll take a look when I have the time.

[N7Huntsman]

Given it's size, .50 cal is probably too much. The turret description calls it an upgrade to the vanilla turret (which uses 5.56mm NATO), so perhaps 7.62mm NATO would be appropriate?

[N7Huntsman]

Seems pretty short, given what they're firing.

[N7Huntsman]

Generally speaking for auto turrets, they don't have a burst fire mode, and simply use automatic with the auto burst being the desired number of rounds (mainly, I suspect, because there's not a flick switch job associated with changing the fire modes). This should be changed for the automated versions of the military turret and precision turret (which I'd make single fire anyway). Can be left for the manned versions, since there's a operator.

[N7Huntsman]

I'm getting an error: Config error in GunComplex: has duplicate thingCategory BuildingsSecurity. Probably just an inheritance issue to resolve.

[N7Huntsman]

Yellow message in logs. Shredder turret gun (12 Gauge) burst fire shot count is same or higher than auto fire. Somewhat odd, given the turret can't be set to burst fire anyway.

[zhrocks11]

So the Issues @N7Huntsman Mentioned above with the Red Errors popping up are related to OUR code, there is currently an issue where human pawns are trying to fire empty turrets..

Once the code is fixed we will be able to / and have to, Retest this patch to make sure there are no residual errors lying around within the patch itself.. At this time we can not test the patch ... I will post another comment when we can resume testing and our internal error has been resolved.

[sumghai]

@zhrocks11 - Thanks for letting me know.

Incidentally, I have also received reports (and have experienced) third-party mod turrets not being reloadable at all by pawns. Do you think that's related to the issue you're seeing? (EDIT: Please disregard the excised comment, as it appears to only occur on old 1.0 CE saves being upversioned to 1.1)