build(medcat-trainer): Improve dockerfile layer caching #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomolopolis
approved these changes
Jan 21, 2026
Member
tomolopolis
left a comment
tomolopolis
left a comment
There was a problem hiding this comment.
lgtm - yes multistage build ftw
alhendrickson
deleted the
build/medcat-trainer/improve-docker-layer-caching
branch
tomolopolis
pushed a commit
that referenced
this pull request
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently as it copies "./" any change to any file makes it cache miss for dependencies. This should fix that.
Reasoning is pulling latest image in k8s is slow right now, as I think it has to redownload all the dependencies every time.
Note - didnt want to rewrite much here, but switching to a multistage build is probably the right thing to do