Conversation
butlerx
force-pushed
the
enchanment/bruteforce-protection
branch
2 times, most recently
from
451d625 to
2718b26
Compare
|
Requires senecajs/seneca-user#54 to be merged and released before this. |
|
Released : senecajs/seneca-user@66981c3 |
|
migration is there but this will need to be updated as final implementation differed from the initial one this was designed for |
|
Are the removed keys duplicates? |
butlerx
force-pushed
the
enchanment/bruteforce-protection
branch
from
0d39144 to
37e6162
Compare
| BEGIN | ||
| ALTER TABLE sys_user ADD COLUMN failed_login_count integer; | ||
| EXCEPTION | ||
| WHEN duplicate_column THEN RAISE NOTICE 'column token already exists in sys_user.'; |
There was a problem hiding this comment.
token -> failed_login_count
butlerx
force-pushed
the
enchanment/bruteforce-protection
branch
3 times, most recently
from
99eb0e6 to
ffce999
Compare
|
seneca-user v2 is now supported with node 8 update |
lib/users/unlock-account-email.js
Outdated
|
|
||
| seneca.act({ role: 'cd-users', cmd: 'get_users_by_email', email }, (err, users) => { | ||
| if (err) return done(err); | ||
| if (options['email-notifications'].sendemail) { |
There was a problem hiding this comment.
unecessary : it's already checked by email-notif:send
service.js
Outdated
| }); | ||
| seneca.use(require('./oauth2.js'), {clients: config.oauth2.clients}); | ||
| seneca.use('user'); | ||
| seneca.use('user', { failedCount: 3 }); |
There was a problem hiding this comment.
options seems to be "failedLoginCount" rather than failedCount
https://github.com/senecajs/seneca-user/blob/8e26f8515fbbc51955096fe707e389c13eaee165/default-options.json#L10
|
To be tested manually for changes between seneca-user 1 -> 2, but code LGTM |
|
https://github.com/CoderDojo/cp-translations/pull/4/files email templates |
…mail asking user to reset when account lockout
butlerx
force-pushed
the
enchanment/bruteforce-protection
branch
from
e220244 to
9d3a78b
Compare
3 participants
add db migration for user lockout
add email asking user to reset when account lockout
requires update to zen to have reset_password link