Add ability to set custom alt. animation suffix #882
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alt. animation toggle event currently does not support setting the suffix directly, but that's outside of the scope of adding this feature at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simply adds the ability to set the alt. animation suffix. As part of this:
DEFAULT_ALT_ANIM_SUFFIX, that sets the default suffix for alt. animations. By default, it is set to-altin order to retain compatibility.StrumLinewas introduced, that beingdefaultAnimSuffix, which is used to replace the suffix per-strumline. By default, it is set to theDEFAULT_ALT_ANIM_SUFFIXflag mentioned above.Alt Animation Togglewill automatically make use of the property above.This change is primarily intended to technically allow for much more alt. animations on a single character without going through the process of a complete character change, thus acting as a more performant variant of theoretically "switching" characters.
Do note that, although the
Alt Animation Toggleevent has been updated to take advantage of the new per-strumline property, it did not receive any changes to allow setting the suffix directly as that is outside of the scope of the pull request (at least, in my opinion).