Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 5 | Prep Exercises

[Nataliia74]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

01 Prep Exercises issue 178

[LonMcGregor]

Very good work on these tasks, there are some areas where you could improve further

Also,consider if it is a good idea to have all these files in the main directory for this sprint

[LonMcGregor]

Good improvements. I think there is still an issue about validating the OSes. You print them out now, which is good, but the program still immediately exits if you type them wrong. Can you get it working like the other inputs where it loops until the input is valid?

Also, did you see my comment asking about the impact of having the prep files all in the main directory rather than a prep specific folder?

[Nataliia74]

Hi Leon, changed a little bit of a script to solve a problem with the OSes validation. Sorry, missed your suggestion to have a separate folder for these files. Why is it a good idea? Because it helps keep my environment clean, organized, and files are grouped according to the topic and which helps me easily make decisions about refactoring or eliminating some files. Also, this custom is useful for safe project scaling.

[LonMcGregor]

These changes look good. Well done!