London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|IMPLEMENT_SHELL_TOOLS Python #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatmaevin
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
| for line in f: | ||
| line_content = line.rstrip("\n") | ||
|
|
||
| if args.b and line_content != "": |
There was a problem hiding this comment.
Do you see the duplication in these two branches of code. Is there some way to simplify this?
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Did you mean to commit all these blank lines at the end?
| if args.chars: | ||
| output.append(str(char_count)) | ||
| output.append(args.file) | ||
| print("\t".join(output)) |
There was a problem hiding this comment.
This part at the end seems repeated. Is there something you could do to simplify this?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist