London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 3|IMPLEMENT_SHELL_TOOLS #272
Conversation
fatmaevin
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks
Remember to add a short summary to your PRs under the template, so I know what it is you have done.
See also my comments in the files
implement-shell-tools/cat/cat.js
Outdated
| const read = await fs.readFile(path, "utf-8"); | ||
| const lines = read.split("\n"); | ||
| for (let i of lines) { | ||
| if (number) { |
There was a problem hiding this comment.
This section has some repetition - two print formats, and two "print a number"s. The nested ifs are also a bit difficult to read. Can you think of any way to tidy this up?
There was a problem hiding this comment.
Thanks for feedback
I created a new function to handle the repeated parts.
implement-shell-tools/wc/wc.js
Outdated
| if (opts.w) return `${counts.words} ${filename}`; | ||
| if (opts.c) return `${counts.bytes} ${filename}`; | ||
|
|
||
| return `${counts.lines} ${counts.words} ${counts.bytes} ${filename}`; |
There was a problem hiding this comment.
If I request multiple files using *, the numbers dont format into columns. Can you figure out why that happens?
There was a problem hiding this comment.
Thanks for the feedback
I used padStart() to align the numbers in columns .
LonMcGregor
added
Reviewed
fatmaevin
added
the
Needs Review
|
Great work! |
LonMcGregor
added
Complete
2 participants
Self checklist