Skip to content

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 4 | Implement shell tools (cat, ls, wc) in Python #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nataliia74 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 4 | Implement shell tools (cat, ls, wc) in Python #264

Nataliia74 wants to merge 6 commits into from

Conversation

@Nataliia74
Copy link

@Nataliia74 Nataliia74 commented Nov 30, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implement shell tools (cat, ls, wc) in Python issue 9

@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025
@Nataliia74 Nataliia74 changed the title Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 4 | Implement shell tools (cat, ls, wc) in Python Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 1 | Implement shell tools (cat, ls, wc) in Python Nov 30, 2025
@DaryaShirokova DaryaShirokova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 28, 2025
DaryaShirokova
DaryaShirokova reviewed Dec 28, 2025
View reviewed changes
Copy link

@DaryaShirokova DaryaShirokova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good first version, left a few comments to address!

@DaryaShirokova DaryaShirokova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 28, 2025
@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 6, 2026
@DaryaShirokova
Copy link

DaryaShirokova commented Jan 10, 2026

@Nataliia74 I've noticed you have added Needs Review label and then the bot removed it. I'll have a look at your pr but please address whatever the bot said as well.

DaryaShirokova
DaryaShirokova reviewed Jan 10, 2026
View reviewed changes
Copy link

@DaryaShirokova DaryaShirokova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added suggestions for improving code structure

@DaryaShirokova
Copy link

DaryaShirokova commented Jan 10, 2026

Finished the review, please have a look at the comment from the github-actions and I can mark the pr as complete once it is resolved

@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@Nataliia74 Nataliia74 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Nataliia74 Nataliia74 added Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Nataliia74 Nataliia74 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Tools The name of the module. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Nataliia74 Nataliia74 changed the title Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 1 | Implement shell tools (cat, ls, wc) in Python Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 3 | Implement shell tools (cat, ls, wc) in Python Jan 13, 2026
@Nataliia74 Nataliia74 changed the title Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 3 | Implement shell tools (cat, ls, wc) in Python Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 4 | Implement shell tools (cat, ls, wc) in Python Jan 13, 2026
@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@DaryaShirokova DaryaShirokova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DaryaShirokova DaryaShirokova DaryaShirokova left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Tools The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nataliia74 @DaryaShirokova