Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 3 | Implement Shell Tools #248

HassanOHOsman · 2025-11-24T23:19:49Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

This PR provides implementations of shell tools: cat, ls, and wc, using JavaScript with Node.js.

Questions

Is the point of implementing those shell command as a way to appreciate the connivance they provide?
Are there any special cases where implementing shell commands might be needed?

Update: Having just stated Sprint 4, I now know that Shell command tools may not provide a full resolution to our problem. So to me, this is an example of when we could resort to building our own custom tools.

…essage and exit the program (unsuccessful).

…ption to handle the number of output lines

…med lines

… user

… files

…he for commander library

… dir

… either a file or a dir

MattGoodwin0

You've got a good understanding of wc, ls and cat commands.

Take a look at the layout of your code files to ensure a consistent format - using a standard format will make it easier to read and review your code.

Could you add some wording around the advantage of having separate package.json files?

MattGoodwin0 · 2025-12-21T21:58:11Z

implement-shell-tools/ls/ls.js

+let allContent = directoryContent;
+
+if (!options.a) {
+    allContent = directoryContent.filter(name => !name.startsWith("."));


What would happen if a directory was not provided - are we able to handle this?

Hi Matt, apologies for the very delayed response!
Thanks for bringing this to my attention.
I've just added validation to handle such a case.
Please review and let me know.

change variable keryword assignemnt for from cosnt to let

HassanOHOsman · 2026-01-09T20:48:20Z

You've got a good understanding of wc, ls and cat commands.

Take a look at the layout of your code files to ensure a consistent format - using a standard format will make it easier to read and review your code.

Could you add some wording around the advantage of having separate package.json files?

Regarding "Could you add some wording around the advantage of having separate package.json files?", was this a question in a backlog? I could not locate it if that was the case.

MattGoodwin0 · 2026-01-23T17:50:07Z

You've got a good understanding of wc, ls and cat commands.
Take a look at the layout of your code files to ensure a consistent format - using a standard format will make it easier to read and review your code.
Could you add some wording around the advantage of having separate package.json files?

Regarding "Could you add some wording around the advantage of having separate package.json files?", was this a question in a backlog? I could not locate it if that was the case.

Not so much a question in the backlog, we would usually expect one package.json, rather than three. Feel free to message on Slack to discuss

HassanOHOsman · 2026-01-23T18:05:25Z

You've got a good understanding of wc, ls and cat commands.
Take a look at the layout of your code files to ensure a consistent format - using a standard format will make it easier to read and review your code.
Could you add some wording around the advantage of having separate package.json files?

Regarding "Could you add some wording around the advantage of having separate package.json files?", was this a question in a backlog? I could not locate it if that was the case.

Not so much a question in the backlog, we would usually expect one package.json, rather than three. Feel free to message on Slack to discuss

My bad! Now I understand. Indeed, it does not make any sense having all 3 of them. Perhaps at the time I presumed that was needed. I will get rid of the extra 2 and ensured that the one package.json remaining is positioned correctly so all 3 folders (cat, ls & wc) have access to it without issues. If for whatever reason this does not work, I will ping you in Slack. Thanks Matt :)

…ccess rather than each one having their own package.json

2. get rid of package-lock.json since a new one can be generated

… running npm install

HassanOHOsman · 2026-01-23T18:39:55Z

Updated as recommended. Hope it looks better now. Thank you :)

HassanOHOsman added 30 commits November 21, 2025 08:47

create cat.js file to implement cat logic in it

df4ff07

import 2 built in NodeJS modules

2ee4991

checks if our program receieves 1 argument otherwise throw an error m…

0931aea

…essage and exit the program (unsuccessful).

storing the one argument in our program into a a variable called path

f8392fa

Read file at the path passed as argument in the programme

23b18aa

rename content var in a more meaningful way

136af7b

log out/display a file content without adding a new line

0f50542

installed commander library and updated the type property in JSON file

2289a8d

improting commander library into js file

b236e17

setting up basic info about our program and most importantly a flag/o…

4f65e6c

…ption to handle the number of output lines

update the program info to include argument

72dab99

commader to interpret the command line arguments based on -n option

b6de478

read all the flags/options provided.

68982c6

cleaning code and getting rid of useless bits

eaf8d3b

splitting the contnet of a file by newline and storing it in a var na…

815dd88

…med lines

build logic for number of lines options

73f9e36

adding a condition as to when the -n option used

bff2e3b

getting rid of numbered trailing empty lines

ee72ac4

define -b option in the porgram info

2ba43de

update logic for -n & -b options

583c011

update & correct logic for -n & -b options

13d12fe

join the array elements by new line and output the formed text to end…

8ba6202

… user

add a scenario as to when the program doesn't contain any -n or -b flags

64ff212

reworking on code so that it handles outputting content from multiple…

bbe5b0c

… files

work on logic to hadle multiple files

ddf594b

update the argument in the program info to handle multiple paths

ee0d711

create ls file to store all the js program logic

d123b19

run teminal commands to add package.json since i'll be using import t…

cd93e63

…he for commander library

import built in and third part modules/libraries into the ls.js file

584666e

uodate the type value to "module" so that i could use "import" keyword

ae56d9b

HassanOHOsman added 9 commits November 24, 2025 18:29

update logic to handl having mutple paths (files) when dealing with a…

eb67a84

… dir

add counters for total lines, words & characters for when the path is…

8a546e1

… either a file or a dir

for the case of a dire print the total coutner

ec4de6a

add -w option in the program basic info

009c40b

flesh out logic to include the -w & -c options

c32410a

code now handles no flag cases for all scenarios (file or dir)

3cc8aaf

update logic to match the wc command line in the way it displays output

397d4e0

house keeping

e155672

remove redantant and repetitive code

d2daa0e

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Nov 24, 2025

MattGoodwin0 suggested changes Dec 21, 2025

View reviewed changes

MattGoodwin0 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 21, 2025

HassanOHOsman added 3 commits January 9, 2026 20:35

validating the path first

4fdb357

add try-catch code block

b2563c1

change

b5866c5

change variable keryword assignemnt for from cosnt to let

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 9, 2026

MattGoodwin0 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026

HassanOHOsman added 3 commits January 23, 2026 18:22

being economical by having 1 package.json for all wc, cat and ls to a…

0e4e1c2

…ccess rather than each one having their own package.json

1.update package.json to acommodate all 3 folders (cat, wc &ls)

6098ccb

2. get rid of package-lock.json since a new one can be generated

generate a new package-lock.josn based on the updated package.json by…

4cdc483

… running npm install

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 3 | Implement Shell Tools #248

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 3 | Implement Shell Tools #248

Uh oh!

HassanOHOsman commented Nov 24, 2025 •

edited

Loading

Uh oh!

MattGoodwin0 left a comment

Uh oh!

MattGoodwin0 Dec 21, 2025

Uh oh!

HassanOHOsman Jan 9, 2026

Uh oh!

HassanOHOsman commented Jan 9, 2026

Uh oh!

MattGoodwin0 commented Jan 23, 2026

Uh oh!

HassanOHOsman commented Jan 23, 2026

Uh oh!

HassanOHOsman commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 3 | Implement Shell Tools #248

Are you sure you want to change the base?

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 3 | Implement Shell Tools #248

Uh oh!

Conversation

HassanOHOsman commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Questions

Uh oh!

MattGoodwin0 left a comment

Choose a reason for hiding this comment

Uh oh!

MattGoodwin0 Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Jan 9, 2026

Uh oh!

MattGoodwin0 commented Jan 23, 2026

Uh oh!

HassanOHOsman commented Jan 23, 2026

Uh oh!

HassanOHOsman commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HassanOHOsman commented Nov 24, 2025 •

edited

Loading