generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 400
London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DamianDL
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
DamianDL:feature/wireframe_new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−19
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a0943dd
Update text to answer three questions in 3 articles, with links.
DamianDL 3e10354
Changes to page formatting into Wireframe template
DamianDL 73b1697
Update to Forms for Sprint 2 exercise
DamianDL 43967f2
centre header text
DamianDL f7fb669
refactor: cleaning up code
DamianDL a4853b6
Delete Code in Form-Controls
DamianDL f054232
added code deleted by mistake
DamianDL 19a6c3b
Merge pull request #1 from DamianDL/feature/wireframe
DamianDL 0ef0bd2
revert accidental change
DamianDL dc22d6e
Update to text and images
DamianDL 13c08a2
Update to text and images
DamianDL 9118e2e
Updated formatting of image alt descriptions and text for page descri…
DamianDL 7254063
update to CSS to set the footer to the bottom of the page on a backgr…
DamianDL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you think of any useful information you can add to your footer instead of the default text?
Other trainees have included:
Any of these 👆 will be an improvement to the default text. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jenny, updates to initial page description, alt text for three pictures and Footer. Thanks for reviewing yesterday.