Skip to content

West Midlands | 25-SDC-July | Gabriel Deng | Sprint 2 | Implement and LRU cache in Python #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gai93003 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

West Midlands | 25-SDC-July | Gabriel Deng | Sprint 2 | Implement and LRU cache in Python #84

gai93003 wants to merge 1 commit into from

Conversation

@gai93003
Copy link

@gai93003 gai93003 commented Jan 23, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@github-actions

This comment has been minimized.

Sign in to view
4 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@gai93003 gai93003 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jan 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@gai93003 gai93003 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
@gai93003 gai93003 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 23, 2026
cjyuan
cjyuan reviewed Jan 25, 2026
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better follow the Single-Responsibility Principle (SRP) in SOLID design principles,
it would be better to implement the "doubly linked list" and the "LruCache" as two separate classes, and then use the linked list in LruChache to enforce order.

Alternatively, use OrderedDict in your solution.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Complexity The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gai93003 @cjyuan