ZA | 25-SDC-July | Luke Manyamazi | Sprint 1 | JavaScript and Python Exercises

[Luke-Manyamazi]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• calculateSumAndProduct (JS): Optimized from two sequential O(N) loops to a single O(N) loop, reducing array traversals by 50%.
• findCommonItems (JS): Reduced time complexity from O(N * M) to O(N + M) by using a Set for O(1) average-time lookups.
• has_pair_with_sum (Python): Reduced time complexity from O(N^2) to O(N) by using a hash set to track complements.
• remove_duplicates (Python): Reduced time complexity from O(N^2) to O(N) by using a hash set to track seen items while preserving order.

Questions

1. Readability vs. Conciseness (JS findCommonItems): I provided both a detailed, multi-line refactor and a concise one-line version for findCommonItems using the Set object. Which style is preferred for functions of this nature in our codebase?

[cjyuan]

Your analysis looks good.

[cjyuan]

Performance can be improved by combining the loops, but the complexity remains O(N).

In complexity analysis, the constant factor is ignored.
N, 2N, or even 100N operations, are all considered as O(N) complexity.

[cjyuan]

I think this "Time Complexity" refers to the complexity of the original code, and the optimal one refers to the refactored code.