ZA | Faith Muzondo | Module-Complexity | Sprint 1 | Analyse and refactor #51
Conversation
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Faithy4444
added
Needs Review
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Faithy4444
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:O(2n) originally have this as using 2 separate loops |
There was a problem hiding this comment.
In complexity analysis, O(2n) is the same as O(n); the constant factor is ignored.
|
|
||
| for (const item of firstArray) { | ||
| if (setB.has(item)) { | ||
| common.add(item); |
There was a problem hiding this comment.
It's usually faster to append an element to an array than adding an item to a set even though both operations are O(1).
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity: O(n) — the function iterates through the input sequence once |
There was a problem hiding this comment.
In the original code, the inner loop would iterate through uniqueItems[]. The complexity is more than O(n).
cjyuan
added
Reviewed
2 participants
Self checklist