Glasgow | Sheetal Kharab | Module-Complexity | Sprint 2 | Implement an LRU cache in Python #39
Conversation
sheetalkharab
added
the
Needs Review
OracPrime
added
the
Review in progress
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
The lru_cache.py is fine (one minor points not really needing correcting). But what are the other files doing in this PR? Presumably they should be in other PRs? And not this one.
| self.size = 0 | ||
|
|
||
|
|
||
| #to remove a node frpm linkedlist |
There was a problem hiding this comment.
typos even in comments can reduce confidence in the reader!
| else: | ||
| self.tail = node.prev | ||
|
|
||
| node.prev = node.next = None |
There was a problem hiding this comment.
A prudent tidy up step: don't let the removed node be able to get back "into" the list.
OracPrime
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Changelist
lru_cache
Questions
no