Conversation
Contributor
Author
alankbi
approved these changes
Jun 29, 2021
Contributor
alankbi
left a comment
There was a problem hiding this comment.
Looks good to me! Left one comment about potentially reusing the line camp component (nice find btw 🙂), but otherwise should be good to merge whenever ready
Contributor
|
Also, lmk if you planned on setting the min-width on this or another PR and I can take a look at that as well (it's a small change though so prob would be fine with just merging that without additional review) |
Contributor
Author
I'll likely do this on another PR with a list of other small changes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of Changes:
/problem/create.Notes:
JSON.stringifycheck on the Back button will sometimes return that the problem was updated, even when it was not.Screencast and Images:
Screencast of the Fix Link Bugs and Update Site Design
Update Description Length on Verified Problems

This image just shows one small portion of the PR.