getUserProfile() default fields

[drezo]

Hello! ✌️

Permissions my application ("locale", "timezone", "gender" unavailable):

Next, we downloaded current version package (1.0.16), used method "getUserProfile()" and get the follow error 😑:

{  
   "error":{  
      "message":"(#100) Insufficient permission to access user profile.",
      "type":"OAuthException",
      "code":100,
      "error_subcode":2018247,
      "fbtrace_id":"CZW1EcCa704"
   }
}

Changed method "getUserProfile()":

getUserProfile(userId, fields) {
    const defaultFields = ['id', 'name', 'first_name', 'last_name', 'profile_pic'];
    if (!Array.isArray(fields)) {
      throw new Error('Fields is supposed to be an array');
    } else Array.prototype.push.apply(defaultFields, fields.map(field => field.trim()));
    const mergeFields = defaultFields.join(',');
    const url = `https://graph.facebook.com/${this.graphApiVersion}/${userId}?fields=${mergeFields}&access_token=${this.accessToken}`;
    return fetch(url)
      .then(res => res.json())
      .catch(err => console.log(`Error getting user profile: ${err}`));
  }

Thanks!

[drezo]

@Charca

What do you say? 🙄

[Charca]

Hey @drezo, thanks for the PR and sorry for the big delay. I haven't been paying much attention to this project or the chatbot scene for the last year, I apologize if this makes your job harder.

The PR looks good for the most part, I left a couple of comments for thing that I'd like to see changed. Please let me know what you think.

[Charca]

Can we give fields a default value of []? Otherwise, the check on line 344 would make the method fail for people who are calling it directly without fields.

[Charca]

It seems that we should change this description. The default value of the fields param is not ['id', 'name', ... ], it's an empty array. When you specify fields, you're not overwriting this default value, you're extending it. I think we should either change the behavior to allow specifying/overwriting all fields, or change this description and maybe the param name to extraFields so that it's clear that you're extending the default. What do you think?

[lehainam-dev]

Hi,
I think this PR is important and resolve a lot issues #150 with recent policy changes of Facebook.
I wonder if @drezo could update the PR?
Thanks.