Add a method to set Express middlewares through BootBot#107
Closed
maximelebastard wants to merge 1 commit intoCharca:masterfrom
Closed
Add a method to set Express middlewares through BootBot#107maximelebastard wants to merge 1 commit intoCharca:masterfrom
maximelebastard wants to merge 1 commit intoCharca:masterfrom
Conversation
Owner
|
Thanks for the PR @maximelebastard, this looks good to me! It looks like a simpler implementation of #104, what do you think @mraaroncruz? |
Collaborator
|
Hmmmm. I like this more than |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of BootBot can face a situation where they have to handle a custom logging format, a security layer or any custom behavior for the Express server.
It would be convenient to be able to set extra Express middlewares before startup of BootBot.