FIREFLY-1919: Add support for UWS jobs that produce non-table results#1907
Open
FIREFLY-1919: Add support for UWS jobs that produce non-table results#1907
Conversation
0c9c1b8 to
05a6451
Compare
05a6451 to
b0b9be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the ability to handle UWS job results other than tables (e.g., images). It introduces dynamic loading based on MIME types and add support for multi-result jobs.
It uses the original search request to process the job, and a configured loader to load the results to the UI based on its MIME type.
In cases where a job produces multiple results, a new selection popup allows the user to choose which result to load.
Tests:
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/irsaviewer/
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/applications/spherex/
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/applications/euclid/
Verified that all existing background job worked as before. Pay extra attention to TAP, IRSA Catalog, Euclid, and SPHEREx SP Tool.
Normally, this operation returns a single table.
To test with a single-image FITS file:
https://dev.irsakubedev.ipac.caltech.edu/api/spherex/spxmosaic/async/sm-6zskz
Upload, thenLoadTo test multi results:
Search