Open
Conversation
…/github.com/CaliDog/certstream-java into add-custom-deserializer-for-list-extensions
|
This pr still solves the parsing errors, at least for me. Thanks! Please merge, so this lib is working again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that this Java library stopped working. With every incoming message a null pointer was thrown. A similar issue already existed for this: #11
The reason for this is probably that the data structure of the Certstream server has changed, but this library has not been adapted to it.
I have compared which data is sent from the Certstream server and which is parsed here in the POJOs. The field "as_der" is no longer included in the data, but was still included in the POJO. The fields "cert_link", "issuer" and "signature_algorithm" were not included in the POJOs.
I have adjusted the POJOs accordingly so that the library works again:
Are you guys okay with the changes like this? If so, it would be good if you could approve the pull request and build a new release so that the library can be used again.
Best regards
Martin