fix(identity): create the identity when missing#10
Merged
kpsherva merged 1 commit intoCERNDocumentServer:mainfrom Oct 30, 2025
Merged
fix(identity): create the identity when missing#10kpsherva merged 1 commit intoCERNDocumentServer:mainfrom
kpsherva merged 1 commit intoCERNDocumentServer:mainfrom
Conversation
Contributor
ntarocco
commented
Oct 29, 2025
ntarocco
commented
- when the identity is missing, the sync will not create it without failing
ntarocco
force-pushed
the
fix/missing-identity
branch
2 times, most recently
from
b3e8b09 to
b0f10b1
Compare
- when the identity is missing, the sync will not create it without failing
ntarocco
force-pushed
the
fix/missing-identity
branch
from
b0f10b1 to
fe6515e
Compare
kpsherva
approved these changes
Oct 29, 2025
Contributor
kpsherva
left a comment
kpsherva
left a comment
There was a problem hiding this comment.
LGTM!
minor: looks like we don't use black in this module
Contributor
Author
I used |
Contributor
#10 (comment) I saw this long line and it gave me the impression that it wasn't formatted. all good then ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.