requests: add docs for new and existing commenting features#1
Merged
kpsherva merged 2 commits intoCERNDocumentServer:mainfrom Jan 16, 2026
Merged
requests: add docs for new and existing commenting features#1kpsherva merged 2 commits intoCERNDocumentServer:mainfrom
kpsherva merged 2 commits intoCERNDocumentServer:mainfrom
Conversation
palkerecsenyi
force-pushed
the
requests
branch
from
d2c84b6 to
26ca56b
Compare
palkerecsenyi
force-pushed
the
requests
branch
from
26ca56b to
f4213ba
Compare
kpsherva
reviewed
Jan 13, 2026
kpsherva
reviewed
Jan 13, 2026
kpsherva
reviewed
Jan 13, 2026
|
|
||
| To quote the full comment, simply click the action menu (the 3 horizontal dots) on the comment you want to quote, and select "Quote reply": | ||
|
|
||
|  |
There was a problem hiding this comment.
not related to the content, side question:
are we OK in the end to lose the default context menu of the right click? "Copy text" will not be possible anymore
Member
Author
There was a problem hiding this comment.
The right click menu is not affected by these changes as far as I'm aware, it should still be possible to right click and e.g. copy text.
kpsherva
reviewed
Jan 13, 2026
docs/review/comments.md
Outdated
| The draft is saved locally in your browser and is **not** synchronised to your account. | ||
| This means your draft will not show up on a different device or browser. | ||
| It can also be lost if you're using a browser on a temporary kiosk computer or if you clear your browser's storage. | ||
| Your draft is restored automatically when you load the page if one can be found. |
There was a problem hiding this comment.
what about if we need to log in again, does it also work?
kpsherva
reviewed
Jan 13, 2026
palkerecsenyi
force-pushed
the
requests
branch
from
ff0edcf to
0893b8a
Compare
palkerecsenyi
force-pushed
the
requests
branch
from
0893b8a to
3108545
Compare
zzacharo
approved these changes
Jan 14, 2026
palkerecsenyi
commented
Jan 14, 2026
Member
Author
palkerecsenyi
left a comment
palkerecsenyi
left a comment
There was a problem hiding this comment.
Reviewed with @sakshamarora1
| - Existing comments cannot be edited | ||
| - Existing comments can still be deleted | ||
| <!-- This is a CDS-specific feature, we should remove it when copying this over to generic docs --> | ||
| - Replying to existing comments is still allowed (replies can be created and deleted but not edited) |
* This does not yet include the file attachments or collapsible comment features
palkerecsenyi
force-pushed
the
requests
branch
from
3108545 to
55c2262
Compare
|
@palkerecsenyi maybe you can add a section also about the notifications on replies/comments? I have added the strategy in the rfc. It requires the publishing of this commit |
github-project-automation
bot
moved this from In progress
to To release 🤖
in Sprint Q1/2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.