feat(facets): parametrize RangeFacet#692
Open
zubeydecivelek wants to merge 1 commit intoCERNDocumentServer:masterfrom
Open
feat(facets): parametrize RangeFacet#692zubeydecivelek wants to merge 1 commit intoCERNDocumentServer:masterfrom
zubeydecivelek wants to merge 1 commit intoCERNDocumentServer:masterfrom
Conversation
zubeydecivelek
force-pushed
the
date-facet
branch
from
8932eaf to
a9ed124
Compare
zubeydecivelek
changed the title
| "InvenioRdmRecords.PublishModal.container": PublishModalComponent, | ||
| "InvenioRequests.LockRequest": LockRequestComponent, | ||
| "InvenioAppRdm.RecordVersionsList.Item.container": RecordVersionItemContent, | ||
| RangeFacet: CDSRangeFacet, |
Member
There was a problem hiding this comment.
Is this missing the full name? I'm not sure what the full name should be but it's something like [${appName}.RangeFacet.element\] right?
Contributor
Author
There was a problem hiding this comment.
This is intentional. We are overriding the full RangeFacet component (registered via Overridable.component("RangeFacet", …) see here) so we can parametrize its behavior.
RangeFacet.element is a separate internal override point, which it's not the target here(we want to customize the optional filters only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs:
should be merge after these PR's