change(config): move config variables to one single place#650
Open
kpsherva wants to merge 1 commit intoCERNDocumentServer:masterfrom
Open
change(config): move config variables to one single place#650kpsherva wants to merge 1 commit intoCERNDocumentServer:masterfrom
kpsherva wants to merge 1 commit intoCERNDocumentServer:masterfrom
Conversation
sakshamarora1
requested changes
Jan 16, 2026
Contributor
sakshamarora1
left a comment
There was a problem hiding this comment.
I think we should move the config.py file to invenio.cfg instead. To keep in sync with other RDM repos. WDYT? Unless there's a solid reason to to move to config.py
Also, for the commit message, it should be refactor:, see https://www.conventionalcommits.org/en/v1.0.0/#specification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.