Open
Conversation
[Feature/user] 폼 유효성 로직 추가
[Feature/user] 기본 레이아웃 & api 세팅
[Feature/user] 로그인/회원가입 API 연결
feat: vote page wip
axios error modify via redirection
oyatplum
reviewed
Jun 29, 2023
oyatplum
left a comment
oyatplum
left a comment
There was a problem hiding this comment.
안녕하세요 Repick 이예지입니다😇
백엔드와 처음 협업하는 과제 하시느라 여러 시행착오가 있으셨을텐데 무사히 마무리 하시느라 수고하셨어요~!
많은 노력이 담긴 코드였던 것 같습니다ㅎㅎ
세션 때 봬요🙏🏻
Comment on lines
+24
to
+26
| message: | ||
| "적어도 한개의 대문자, 소문자, 숫자, 특수문자를 포함해서 8자 이상으로 입력해주세요", | ||
| }; |
Comment on lines
+12
to
+23
| const [isHovered1, setIsHovered1] = useState(false); | ||
| const [isHovered2, setIsHovered2] = useState(false); | ||
|
|
||
| const navigate = useNavigate(); | ||
|
|
||
| const handleMouseEnter = ({ type }: IVRprops) => { | ||
| type === 1 ? setIsHovered1(true) : setIsHovered2(true); | ||
| }; | ||
|
|
||
| const handleMouseLeave = ({ type }: IVRprops) => { | ||
| type === 1 ? setIsHovered1(false) : setIsHovered2(false); | ||
| }; |
There was a problem hiding this comment.
onMouseLeave를 통해 hover를 state로 처리하는 것도 좋은 아이디어네용!!!
Comment on lines
+26
to
+31
| export const GET = (url: string, params?: any) => | ||
| fetchWrap({ method: "get", url, params }); | ||
|
|
||
| export const POST = (url: string, body: any, params?: any) => | ||
| fetchWrap({ method: "post", url, body, params }); | ||
|
|
Comment on lines
+61
to
+65
| if (window.confirm(`${person.name}님에게 투표하시겠습니까?`) === true) { | ||
| handleVote(person.name); | ||
| // handletest(person.name); | ||
| } else { | ||
| alert("취소되었습니다."); |
sujinRo
reviewed
Jun 30, 2023
sujinRo
left a comment
sujinRo
left a comment
There was a problem hiding this comment.
안녕하세요! 댄서포트 팀 노수진입니다.😊
Hooking 팀의 코드가 너무 잘 정리 되어있어서, 리뷰를 하기 좋았고, 또, 이후 있을 협업에서 적용해야겠다고 생각한 부분들이 많이 있었습니다!
이번과제도 수고하셨습니다!👍
There was a problem hiding this comment.
공통 color을 따로 정리해두니까 더 편리하고, 협업에 유용할 것 같아요!
팀 플젝때는 이용해야겠어요,,
| localStorage.setItem("accessToken", accessToken); | ||
| cookies.set("refreshToken", refreshToken, { path: "/" }); | ||
| }; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 Hooking팀의 김문기, 장효신입니다~!
최대한 간단하게 작업하기 위해 노력하였고(간단하지않았지만)
다수의 이미지를 가져다 쓰면서 최소한의 양심을 위해
image sprite 기술을 사용해 나름의 최적화를 하였습니다.
react-hook-form을 통해 회원가입과 로그인 단게에서의 코드 량을 줄였습니다~!
배포링크