Improve handling of ris-live HTTP errors#155
Open
pforemski wants to merge 2 commits intoCAIDA:masterfrom
Open
Conversation
Member
|
Hey! The integer overflow bug is a nice catch. Thanks. I'm not too sure about handling the read error like that, so I'll have to spend some quality time with the code to double check that it doesn't have unwanted side effects (it's probably ok, but since that code is right in the core of bgpstream, i just want to be extra careful). I do think however, that when we get EOF from the transport (the 0 return), then we should return END_OF_DUMP. Remember that we don't know what transport we are reading the data over, so it is perfectly reasonable to be reading ris-live formatted data from a file (indeed this is how we test things). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
While debugging ris-live errors (
HTTP ERROR: Transferred a partial file (18)) I found a few small issues in the code, fixed/improved in the below 2 commits.Thanks for your great work!