Remove GodotSink and remaining GD.Print calls#538
Merged
esbudylin merged 3 commits intoC7-Game:Developmentfrom Jan 14, 2026
Merged
Remove GodotSink and remaining GD.Print calls#538esbudylin merged 3 commits intoC7-Game:Developmentfrom
esbudylin merged 3 commits intoC7-Game:Developmentfrom
Conversation
Member
|
It's been a long time since I looked at logging, but how did you conclude that GodotSink is unused? I thought it was providing some kind of global service. |
Contributor
Author
My reasoning was that the I guess the question here is whether we still need |
TomWerner
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like this is already mostly done. There were only two
GD.Prints, and all of theConsole.WriteLines are in places where they should be (BuildDevSaveandC7GameDataTests). It also seems likeGodotSinkisn't needed anymore, so I removed it.Closes #258