Added 'PENDING' status check when videos come from jsonobject#6
Open
tkandala wants to merge 1 commit intoBrightcoveOS:masterfrom
Open
Added 'PENDING' status check when videos come from jsonobject#6tkandala wants to merge 1 commit intoBrightcoveOS:masterfrom
tkandala wants to merge 1 commit intoBrightcoveOS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We at the Toronto Star (thestar.com) are using the Brightcove OS library to pull in modified videos from Brightcove. We found an issue where once in a while, a video status equal to 'PENDING' comes in from brightcove, an exception is thrown inside video.java (as it is only checking for "ACTIVE", "INACTIVE" or "DELETED"). When this happens, we are not able to put in the modified videos inside our CMS and thus causing a complete lockdown. We found out that when we delete that video with 'PENDING' status inside brightcove, the json request starts to work without any issues.
We have seen this issue being raised on Google searches so we added an extra check to check for the 'PENDING' status when video list is created inside video.java