Skip to content

Conversation

@andrew-polk
Copy link
Contributor

@andrew-polk andrew-polk commented Jan 28, 2026


Open with Devin

This change is Reviewable

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

@greptile-apps
Copy link

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

Fixed GIF placeholder display by excluding .bloom-gif elements from receiving the default image placeholder. GIF canvas elements now correctly use their custom placeholder (defined in editMode.less:1299) instead of the generic flower placeholder.

  • Added :not(.bloom-gif) selector to line 25 in placeHolderImages.less
  • Added explanatory comment noting that GIFs have their own placeholder
  • Change is minimal, targeted, and follows existing pattern of conditional styling
  • No issues found

Important Files Changed

Filename Overview
src/BloomBrowserUI/placeHolderImages.less Added :not(.bloom-gif) selector to exclude GIF elements from receiving the default image placeholder, allowing GIFs to use their custom placeholder (defined in editMode.less)

Sequence Diagram

sequenceDiagram
    participant Browser as Browser Renderer
    participant CSS as placeHolderImages.less
    participant Element as Canvas Element
    
    Browser->>Element: Render canvas-element with placeHolder.png
    Element->>CSS: Check CSS selectors
    
    alt Element has .bloom-gif class
        CSS->>Element: Skip image-placeholder-background()
        Note over Element: Uses custom GIF placeholder<br/>from editMode.less
    else Element does not have .bloom-gif class
        CSS->>Element: Apply image-placeholder-background()
        Note over Element: Shows default flower<br/>placeholder SVG
    end
    
    Element->>Browser: Display appropriate placeholder
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@andrew-polk andrew-polk force-pushed the BL15758_GifPlaceholder branch from cdb6d48 to 64e850f Compare January 29, 2026 04:50
Copy link
Contributor

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrew-polk).

@StephenMcConnel StephenMcConnel merged commit e08c63b into Version6.3 Jan 29, 2026
2 checks passed
@StephenMcConnel StephenMcConnel deleted the BL15758_GifPlaceholder branch January 29, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants