Closed
Conversation
wifiConnectivityWindow.ui: change horizontalLayout to a vertical layout with a listview and a vertical scrollbar wifiConnectivityWindow.py: generated file from QtDesigner with some optimizations Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
…e need to use wificonnectivitywindow_ui
gmmcosta15
added
UI/UX
gmmcosta15
force-pushed
the
ref/network_window
branch
from
7550a48 to
b937cab
Compare
gmmcosta15
force-pushed
the
ref/network_window
branch
from
b937cab to
c63aa87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
**BlocksScreen/lib/network.py:**´
get_device_ip_by_interfaceto get IPv4 address for a specific interface via NetworkManager D-Bus.BlocksScreen/lib/panels/networkWindow.py
wifiConnectivityWindowfile.QRunnabletask emittedto the threadpool.QtWidgets.QListWidgetItemto use our custom EntryDelegate and each network is a EntryList.WiFiandHotspottoggle button are protected byQtCore.QSignalBlockerto make them always sync.BlocksScreen/lib/ui/resources/icon_resources.qrc:
BlocksScreen/lib/utils/list_model.py:
BlocksScreen/lib/utils/blocks_Scrollbar.py:
BlocksScreen/lib/utils/blocks_linedit.py:
Motivation
Improve Responsiveness: Perform network refreshes off the main thread to avoid UI freezes.Increase Usability: Support hidden networks and separate saved/unsaved networks visually.Enhance Maintainability: Use constants and programmatic UI to simplify future updates.Increase Stability: Add robust error handling and synchronized toggle state.Improve UX: Update icons to reflect signal and security types and streamline network list behavior.
Screenshots
Before
After
Tests
Tested on RF50,
Missing Unit and Integration Tests,
Co-Authors
Co‑author: @Robert0Mart
Co‑author: @claudiobrinca