Open
Conversation
…current_dir is deleted
…duced, in case of not loading the thumbnail of a file always shows the blocksthumbnail file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
BlocksScreen/lib/files.py:
initial_load()notify_filelist_changed: updates internal state incrementallyBlocksScreen/lib/panels/mainWindow.py:
BlocksScreen/lib/panels/widgets/filesPage.py:
files.pyand adapts theEntryListModelaccordinglyUSB-<name>BlocksScreen/lib/utils/list_model.py:
remove_item_by_textinsert_itemto insert an item at a specific indexMotivation
This refactor improves the file list handling flow by separating full initial loading from incremental updates, which leads to better
Tests
Tested on RF50,
Missing Unit and Integration Tests,
Future work
Creating unit and integration tests, and handle of the
root_updatemethod called when the gcodes folder is changed