Skip to content

Refactor Network Window #135

Closed
gmmcosta15 wants to merge 33 commits intodevfrom
ref/network_window
Closed

Refactor Network Window #135
gmmcosta15 wants to merge 33 commits intodevfrom
ref/network_window

Conversation

@gmmcosta15
Copy link
Collaborator

What Changed?

lib/panels/networkWindow.py

  • Network Window - Main Page : Refactored the window from a ListCustomButton to a QListView using MVC architecture
  • Changed BuildNetworkList from QtCore.QThread to a QtCore.QObject that uses a QThreadPool to run NetworkScanRunnable tasks periodically. with a QTimer to trigger scans. Prevents overlapping scans by tracking whether a scan is already in progress.
  • Changed Wifi Icons for the status of the network

Screenshots

Before

Captura de ecrã 2025-12-12 125550

After

Captura de ecrã 2025-12-12 152508

Future Work

  • Consider possible optimizations: Creating own costum UI method instead of using the Ui_wifi_stacked_page
  • Unit and Integration Tests

Co-Authors

Co‑author: @Robert0Mart
Co‑author: @claudiobrinca

gmmcosta15 and others added 12 commits December 11, 2025 17:37
wifiConnectivityWindow.ui: change horizontalLayout to a vertical layout with a listview and a vertical scrollbar
wifiConnectivityWindow.py: generated file from QtDesigner with some optimizations

Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
@gmmcosta15 gmmcosta15 requested a review from HugoCLSC December 16, 2025 14:34
@gmmcosta15 gmmcosta15 self-assigned this Dec 16, 2025
@gmmcosta15 gmmcosta15 added the UI/UX User Interface what changed with this code label Dec 16, 2025
@gmmcosta15 gmmcosta15 closed this Dec 17, 2025
@gmmcosta15 gmmcosta15 reopened this Dec 17, 2025
@gmmcosta15 gmmcosta15 closed this Jan 2, 2026
@gmmcosta15 gmmcosta15 reopened this Jan 2, 2026
@gmmcosta15 gmmcosta15 marked this pull request as draft January 15, 2026 09:45
Base automatically changed from dev to main January 16, 2026 16:52
RF50_DATASHEET_PAGE = (
"https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf"
)
RF50_DATASHEET_PAGE = "https://www.blockstec.com/assets/downloads/rf50_datasheet.pdf"
"fan": QtGui.QPixmap(":/fan_related/media/btn_icons/fan.svg"),
}

self.panel.cp_z_tilt_btn.clicked.connect(lambda: self.handle_ztilt())
wifi_toggle = self.panel.wifi_button.toggle_button
hotspot_toggle = self.panel.hotspot_button.toggle_button

blockers = (
def _run_command(self, command):

def _run_command(self, command: str):
"""Schedule a reschedule timer"""
try:
self._delayed_action_timer.timeout.disconnect()
except TypeError:

def get_file_loc(filename) -> pathlib.Path:
...
def get_file_loc(filename) -> pathlib.Path: ...
# return
# self._configure_option_cards(_keys)
if isinstance(config, list):
...
@gmmcosta15 gmmcosta15 changed the base branch from main to dev January 19, 2026 15:41
@gmmcosta15 gmmcosta15 added the Refactor Enhancing code's readability, maintainability, and extensibility while addressing technical debt. label Feb 3, 2026
@gmmcosta15 gmmcosta15 changed the title Refactor Network Window: Change Network Wifi List from ListCustomButton to a QListView Refactor Network Window Feb 3, 2026
@gmmcosta15 gmmcosta15 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Enhancing code's readability, maintainability, and extensibility while addressing technical debt. UI/UX User Interface what changed with this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants