SQL-based paging everywhere, and various other changes#16
Open
FlorentLM wants to merge 87 commits intoBinaryBrain:mainfrom
Open
SQL-based paging everywhere, and various other changes#16FlorentLM wants to merge 87 commits intoBinaryBrain:mainfrom
FlorentLM wants to merge 87 commits intoBinaryBrain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As disussed in this issue, here's the PR that implements SQL-based paging.
However it also includes pretty heavy rewrites of the response-construction logic (and thus, of all endpoints functions), along with other minor additions / changes.
Full list (I think?):
m3uformat including Beet'splaylistandsmartplaylistplugins' playlists (as well as Beetstream's ownplaylist_diroption of course)ffmpegif the user donesn't have the python module installedgetAlbumInfoandgetAlbumInfo2endpointsid, etc) and for consistencyTested with the following clients:
Gonna start implementing support for authentication in another branch and then will add the missing endpoints :)
Cheers!