-
Notifications
You must be signed in to change notification settings - Fork 18
add new model Liu_IFACPapersOnLine2025 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
approved these changes
Jan 22, 2026
Collaborator
dilpath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, and thanks for fixing the other model metadata in the README
dweindl
added a commit
to AMICI-dev/AMICI
that referenced
this pull request
Jan 28, 2026
Skip the recently added `Liu_IFACPapersOnLine2025` (Benchmarking-Initiative/Benchmark-Models-PEtab#260) benchmark collection problem. Fixes the following test failure (https://github.com/AMICI-dev/AMICI/actions/runs/21275130982/job/61233254223): `FAILED tests/benchmark_models/test_petab_benchmark_jax.py::test_jax_llh[Liu_IFACPapersOnLine2025] - NotImplementedError: The JAX backend does not support event assignments with implicit triggers.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for the submission of new PEtab problems
The PEtab problem is based on a model that is peer-reviewed and published
The problem ID is in the format
$\to$ We use
{LAST_NAME_OF_FIRST_AUTHOR}_{ABBREVIATED_JOURNAL_NAME}{YEAR_OF_PUBLICATION}IFACPapersOnLineinstead of the ISO Journal abbreviation due to the-that can not be used in SBMLidThe problem ID is in the pull request title
There is a GitHub issue for this problem: closes Add Liu_IFACPapersOnLine2025 #257
The SBML file
PEtab files
petablint -vy problem.yaml)The PEtab problem author(s) are assigned to the GitHub issue
The README has been updated with
bmp-create-overview --update(requirespip install -e src/python/bmpfrom the repository root)closes Add Liu_IFACPapersOnLine2025 #257