Update docstring for GeoDR Failover to Geo-Replication#32676
Update docstring for GeoDR Failover to Geo-Replication#32676EldertGrootenboer wants to merge 1 commit intoAzure:devfrom
Conversation
EldertGrootenboer
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Hi @EldertGrootenboer, |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR updates the docstring for the Azure Service Bus namespace failover command to use "Geo-Replication Failover" instead of "GeoDR Failover" to clarify that this relates to the new Geo-Replication feature.
Changes:
- Updated class docstring from "GeoDR Failover" to "Geo-Replication Failover"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| class Failover(AAZCommand): | ||
| """GeoDR Failover | ||
| """Geo-Replication Failover |
There was a problem hiding this comment.
While updating this docstring from "GeoDR" to "Geo-Replication" improves clarity, there are other occurrences of "GeoDR" in the codebase that should also be updated for consistency. Specifically:
- src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_create.py line 236: "GeoDR Role Types"
- src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_update.py line 99: "GeoDR Role Types"
Consider updating these references to use "Geo-Replication" terminology consistently across the module.
3 participants
Related command
az servicebus namespace failover
Description
Clarify that this is for the new Geo-Replication feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.