Skip to content

Support azdev test to auto cleanup pyc files and recordings when live test failed#267

Open
YalinLi0312 wants to merge 4 commits intoAzure:devfrom
AME-Redmond:dev-test
Open

Support azdev test to auto cleanup pyc files and recordings when live test failed#267
YalinLi0312 wants to merge 4 commits intoAzure:devfrom
AME-Redmond:dev-test

Conversation

@YalinLi0312
Copy link

@YalinLi0312 YalinLi0312 commented Nov 12, 2020

For issue #208

@YalinLi0312 YalinLi0312 self-assigned this Nov 12, 2020
@YalinLi0312 YalinLi0312 added the Test azdev test label Nov 12, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 12, 2020

@haroldrandom to help with.

@YalinLi0312
Copy link
Author

YalinLi0312 commented Nov 30, 2020

@haroldrandom This PR is literally split out from previous big PR, it has addressed your comments there, and excludes the multi-process implementation. Do you have any new comments? Could we wrap up this week?

@qwordy
Copy link
Member

qwordy commented Dec 1, 2020

Does recording file have debug info that is useful?

@YalinLi0312
Copy link
Author

YalinLi0312 commented Dec 1, 2020

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

@qwordy
Copy link
Member

qwordy commented Dec 2, 2020

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

This PR removes recording files when a test fails. Right? Is it possible that people need the recording files to debug?

RenSilvaAU pushed a commit to RenSilvaAU/azure-cli-dev-tools that referenced this pull request Aug 7, 2025
@necusjz
Merge pull request Azure#267 from necusjz/release-v1.5.0
08efb02 
Release v1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qwordy qwordy Awaiting requested review from qwordy

@jsntcy jsntcy Awaiting requested review from jsntcy

@yungezz yungezz Awaiting requested review from yungezz

@bquantump bquantump Awaiting requested review from bquantump

@yonzhan yonzhan Awaiting requested review from yonzhan

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

At least 1 approving review is required to merge this pull request.

Assignees

@YalinLi0312 YalinLi0312

Labels

Test azdev test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YalinLi0312 @yonzhan @qwordy