FEAT: Adding pyrit_version to identifiers #1334
Open
+400
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our original
scorer_identifier, I explicitly removedpyrit_versionfrom the identifier because we don't want it as part of the hash (e.g. if thepyrit_versionchanges, we don't want to have to re-calculate scorer metrics).Now that we have more robust general
Identifiers, this PR adds it back.Also added tests and refactored for readability (clearly separating hashes and storage metadata exclusion keys).