Open
Conversation
DomT602
requested changes
Mar 30, 2020
Member
DomT602
left a comment
DomT602
left a comment
There was a problem hiding this comment.
Good idea however, this needs to be thought about more carefully as not every use of call compile can translate into parseSimpleArray. I've marked a few examples but there are more.
| life_delivery_in_progress = true; | ||
|
|
||
| life_dp_point = call compile format ["%1",_dp]; | ||
| life_dp_point = parseSimpleArray format ["%1",_dp]; |
Member
There was a problem hiding this comment.
We've gotta be careful, not every call compile can become parseSimpleArray. In this instance, there is no array, as once compiled its an object.
Contributor
There was a problem hiding this comment.
that could become missionNamespace getVariable _dp tho :)
or maybe missionNamespace getVariable [_dp, objNull] with isNull check to be safe
|
|
||
| private _unit = lbData[2902,lbCurSel (2902)]; | ||
| _unit = call compile format ["%1", _unit]; | ||
| _unit = parseSimpleArray format ["%1", _unit]; |
Contributor
There was a problem hiding this comment.
don't touch these, I want to do them in a seperate pr (already prepared that one)
| */ | ||
| private _unit = lbData[2902,lbCurSel (2902)]; | ||
| _unit = call compile format ["%1", _unit]; | ||
| _unit = parseSimpleArray format ["%1", _unit]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #511
Changes proposed in this pull request:
Move
call compiletoparseSimpleArraywhere possible.I have tested my changes and corrected any errors found