Skip to content

[OGUI-1859] Unify display of drawing options #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
generatedkeys wants to merge 48 commits into
base: dev
Choose a base branch
from
Open

[OGUI-1859] Unify display of drawing options #3291

generatedkeys wants to merge 48 commits into from

Conversation

@generatedkeys
Copy link
Collaborator

@generatedkeys generatedkeys commented Jan 18, 2026 •
edited
Loading

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

@generatedkeys
feature: add toggle button for objectInfoPanel and add drawingOptions…
7b346c8 
… panel to objectViewPage
@generatedkeys
fix: drawing options handling and setting non-recognized options
d4f4cb5
@generatedkeys
fix: ensure non-recognized drawing options are displayed only when pr…
9d00c59 
…esent
@generatedkeys
fix: update initial drawing options handling and improve logic
97e9b52
@generatedkeys
tests: add drawing options panel visibility tests and update plot upd…
a0f6923 
…ate on toggle drawing option
@generatedkeys
test: update filter tests and drawing options tests for object view f…
488c811 
…rom object tree
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
158ee06 
…ect-view
@generatedkeys
tests: object view from layout view for drawing options
b1c2ddc
@generatedkeys
tests: fix linting
573a386
@generatedkeys
tests: remove unnecessary comma
2b07cbb
@generatedkeys
test: fix expand object details for drawing options panel button access
70603e9
@generatedkeys
test: clarify comment for drawing options panel toggle button
0f1bd54
@generatedkeys
test: fix and add layout tests for drawing options on object view page
67d1b41
@generatedkeys
test: add LAYOUT_MOCK_7 and update layout tests with the new mock item
d63620b
@generatedkeys
test: add test for displaying unrecognized drawing options in the dra…
07f7de9 
…wing options panel
@generatedkeys
fix: correct ignoreDefaults and nonRecognized drawing options logic
fcc4d40
@generatedkeys
fix: remove unnecessary key for redraw on show/hide drawingOptions panel
bed6cb3
@generatedkeys
fix: update drawing options panel ensuring correct order and improvem…
2d3a442 
…ents test assertions
@generatedkeys
fix: improve variable naming for object info card
d672579
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
13f90b6 
…ect-view
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
9f34119 
…ect-view
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
9e77475 
…ect-view
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
25f982a 
…ect-view
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
74466a1 
…ect-view
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
785e2e2 
…ect-view
@generatedkeys
fix: remove redundant import
35f579b
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1821/jsroot-draw-options-obj…
3707bc6 
…ect-view
@generatedkeys
fix: correct typo in license comment
0639594
@generatedkeys
fix: consolidate import statements for drawing options
7e44283
@generatedkeys
fix: correct typo in license comment
a0e2b91
@generatedkeys generatedkeys self-assigned this Jan 18, 2026
@generatedkeys generatedkeys changed the title [OGUI-1859] - Unify display of drawing options [OGUI-1859] Unify display of drawing options Jan 18, 2026
@generatedkeys generatedkeys marked this pull request as ready for review January 20, 2026 09:34
graduta and others added 10 commits January 20, 2026 18:22
@graduta
Merge branch 'dev' of github.com:AliceO2Group/WebUi into feature/QCG/…
bc9a21b 
…OGUI-1821/jsroot-draw-options-object-view
@hehoon
Update QCG version from 3.18.0 to 3.19.0
06fe225
@hehoon
Apply fix for preview drawing options feature after dev branch merge
6436aad
@hehoon
test: wait for the ignoreDefaults checkbox state and clarify `expecte…
74f12fe 
…dDrawingOptions`
@hehoon
test: add a short delay to ensure the ignoreDefaults checkbox state…
6933008 
… and GUI are fully updated after click.
@hehoon
test: remove screenshotting the page
12f0e92
@hehoon
Merge branch 'dev' of github.com:AliceO2Group/WebUi into feature/QCG/…
ec67142 
…OGUI-1859/unify-display-of-drawing-options
@hehoon
Merge branch 'feature/QCG/OGUI-1821/jsroot-draw-options-object-view' …
0352d09 
…of github.com:AliceO2Group/WebUi into feature/QCG/OGUI-1859/unify-display-of-drawing-options
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1859/unify-display-of-drawin…
84c290d 
…g-options
@generatedkeys
Merge branch 'dev' into feature/QCG/OGUI-1859/unify-display-of-drawin…
c5e658a 
…g-options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@generatedkeys generatedkeys

Labels

Frontend Quality Control

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@generatedkeys @graduta @hehoon