[PWGJE,EMCAL-1154] Add crosstalk emulation#11538
[PWGJE,EMCAL-1154] Add crosstalk emulation#11538mhemmer-cern merged 1 commit intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 8 errors, |
|
This PR needs this one from O2: AliceO2Group/AliceO2#14385 |
mhemmer-cern
force-pushed
the
EMCAL-1154
branch
2 times, most recently
from
07c5b60 to
f2471a4
Compare
mhemmer-cern
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa and
nzardosh
as code owners
|
First version of the cross talk emulation. Newly generated cells will not be filled in the |
|
@fjonasALICE looks good to me (Sorry for the delay from my side). I think the effect can then only be evaluated once its merged and we check the M02 distributions etc. on the full MC production. |
|
There is a commit coming with updated default values based on the feedback I received. |
|
@mhemmer-cern approved but now there are merge conflicts, please fix and ping me again |
Adds EMCal cross talk emulation for MC. Configurables are handled via `EmcCrossTalkConf` inside the correction task. The cross talk itself is contained within `emcalCrossTalkEmulation.cxx` and `emcalCrossTalkEmulation.h`. Since the cross talk can create new cells which are not inside the AO2Ds original cell table, those new cells will not be stored within the table that mappes clusterIDs to cellIDs! [PWGJE,EMCAL-1154] Update default values - Added link to the default yaml file for the emcal configuration from where the deafult values where taken and added newer default values with reference to this paper: https://cds.cern.ch/record/2910556/
|
@fjonasALICE @jokonig I updated to PR, working on the merge conflicts. Please check carefully. I hope I did not accidentally remove anything from the previous PRs. |
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
4 participants
Adds EMCal cross talk emulation for MC.
Configurables are handled via
EmcCrossTalkConfinside the correction task. The cross talk itself is contained withinemcalCrossTalkEmulation.cxxandemcalCrossTalkEmulation.h. Since the cross talk can create new cells which are not inside the AO2Ds original cell table, those new cells will not be stored within the table that mappes clusterIDs to cellIDs!