Event mixing: Do not use arrow functions in groupTable#14501
Event mixing: Do not use arrow functions in groupTable#14501ktf merged 7 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Please consider the following formatting changes to AliceO2Group#14501
|
Looks good, thanks. Which tests did you do to validate the results? |
I ran event mixing tutorial tasks (file eventMixing.cxx in O2Physics/Tutorials/src) and checked that the console output of these tasks doesn't change with this PR. I performed the benchmark with the following code that is not merged yet, but I can make a PR for that after my vacations: https://github.com/saganatt/AliceO2/blob/mixing-benchmark-simplify-group-table/Framework/Core/test/benchmark_EventMixingParts.cxx |
Rewrite groupTable() to use the O2 table iterators instead of manually iterating over Apache Arrow chunked columns.
Credits to @mytkom for the idea and most of the implementation.
It gives a 2x speed-up to the creation of a blocked combination policy -- see the results (mean of 5 benchmark runs) in the table below.
This does not affect the running time of creation of a combination generator and generation of combinations.
FYI @mytkom @chefxxx @MykhailoShamrai