TRD: decrease default --max-delay for gain, t0, vdexb calibrations#14478
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Jul 4, 2025
Merged
TRD: decrease default --max-delay for gain, t0, vdexb calibrations#14478shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02 merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
requested changes
Jul 3, 2025
| Options{ | ||
| {"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}}, | ||
| {"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}}, | ||
| {"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}}, |
Collaborator
There was a problem hiding this comment.
should be VariantType::Float
Collaborator
Author
There was a problem hiding this comment.
ah yes, sorry about that
| Options{ | ||
| {"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}}, | ||
| {"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}}, | ||
| {"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}}, |
| Options{ | ||
| {"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}}, | ||
| {"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}}, | ||
| {"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}}, |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 256f5b5 at 2025-07-03 19:28: Full log here. |
shahor02
reviewed
Jul 3, 2025
| Options{ | ||
| {"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}}, | ||
| {"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}}, | ||
| {"max-delay", VariantType::VariantType::Float, 0.05f, {"number of slots in past to consider"}}, |
shahor02
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.