ITS: tracker shadowed variable #14390
Merged
mconcas merged 4 commits intoAliceO2Group:devfrom Jun 12, 2025
Merged
Conversation
Collaborator
f3sch
commented
Jun 11, 2025
f3sch
commented
- sets the memory limit to high by default effectively disabling it (also then not printing it as config)
- use LOG instead of std::cost in TF
- rework the prepareCluster function a bit to use std more and not double loop
- also I saw in one test a crash if no tracks were produced, I suspect this was not really a problem and the code handled it before correctly but if no tracks were found we can skip all this entirely anyways
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mconcas
approved these changes
Jun 12, 2025
mhemmer-cern
pushed a commit
to mhemmer-cern/AliceO2
that referenced
this pull request
Sep 9, 2025
* ITS: set default mem to high Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * ITS: fix output crash if zero tracks where found Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * ITS: tracker fix shadowed variable Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> * ITS: minor adjustments in TF Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch> --------- Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.