Skip to content

fix DIM string buffer crash #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sy-c wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

fix DIM string buffer crash #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60be108
fix crash, DIM return string buffer lifetime
sy-c Feb 5, 2026
e2e1fe1
Merge remote-tracking branch 'upstream/master'
sy-c Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/DimServices/DimServices.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,18 @@ void StringRpcServer::rpcHandler()
alfDebugLog.info("Request received on %s : %s",mServiceName.c_str(),getString());
try {
auto returnValue = mCallback(std::string(getString()));
setDataString(makeSuccessString(returnValue), *this);
auto reply = makeSuccessString(returnValue);
mDimBuffer = toCharBuffer(reply, true); // keep buffer alive
setData(mDimBuffer.data(), mDimBuffer.size());
rtrim(returnValue);
alfDebugLog.info("Request completed: %s", returnValue.c_str());
} catch (const std::exception& e) {
if (kDebugLogging) {
Logger::get() << mServiceName << ": " << e.what() << LogErrorDevel_(5100) << endm;
}
setDataString(makeFailureString(e.what()), *this);
auto reply = makeFailureString(e.what());
mDimBuffer = toCharBuffer(reply, true); // keep buffer alive
setData(mDimBuffer.data(), mDimBuffer.size());
alfDebugLog.error("Request failure: %s", e.what());
}
}
Expand Down
1 change: 1 addition & 0 deletions src/DimServices/DimServices.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class StringRpcServer : public DimRpcParallel

Callback mCallback;
std::string mServiceName;
std::vector<char> mDimBuffer; // owns DIM data
};

// CLIENT
Expand Down